Skip to content

ES|QL: Fix release yamlRestTest #133820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

ES|QL: Fix release yamlRestTest #133820

merged 1 commit into from
Aug 29, 2025

Conversation

@leontyevdv
Copy link
Contributor

@leontyevdv leontyevdv commented Aug 29, 2025 •
edited
Loading

To reproduce:

./gradlew ":x-pack:plugin:esql:qa:server:single-node:yamlRestTest" --tests "org.elasticsearch.xpack.esql.qa.single_node.EsqlClientYamlIT.test {p0=esql/60_usage/Basic ESQL usage output (telemetry) non-snapshot version}" -Dtests.seed=74340BA13985282B -Dbuild.snapshot=false -Dtests.jvm.argline="-Dbuild.snapshot=false" -Dlicense.key=x-pack/license-tools/src/test/resources/public.key -Dtests.locale=ki-Latn-KE -Dtests.timezone=America/El_Salvador -Druntime.java=24

Failed build: https://gradle-enterprise.elastic.co/s/ojsn52vw6435c

@leontyevdv leontyevdv self-assigned this Aug 29, 2025
@leontyevdv leontyevdv added >test Issues or PRs that are addressing/adding tests :StorageEngine/TSDB You know, for Metrics Team:StorageEngine v9.2.0 :StorageEngine/ES|QL Timeseries / metrics / logsdb capabilities in ES|QL labels Aug 29, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@jordan-powers jordan-powers added the test-release Trigger CI checks against release build label Aug 29, 2025
jordan-powers
jordan-powers approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@jordan-powers jordan-powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@leontyevdv leontyevdv merged commit b3ad92a into elastic:main Aug 29, 2025
33 checks passed
JeremyDahlgren pushed a commit to JeremyDahlgren/elasticsearch that referenced this pull request Aug 29, 2025
@leontyevdv @JeremyDahlgren
ES|QL: Fix release yamlRestTest (elastic#133820)
6379f46
@jordan-powers jordan-powers mentioned this pull request Aug 29, 2025
Merged
jordan-powers added a commit that referenced this pull request Sep 2, 2025
@jordan-powers
Increment expected function count in ESQL test (#133853)
2404e24 
In f2b364c we added another function, which broke this test, which we fixed in #133820.
We then immediately added another function in 97abc87, so let's fix this test again here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordan-powers jordan-powers jordan-powers approved these changes

@not-napoleon not-napoleon Awaiting requested review from not-napoleon

Assignees

@leontyevdv leontyevdv

Labels

:StorageEngine/ES|QL Timeseries / metrics / logsdb capabilities in ES|QL :StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leontyevdv @elasticsearchmachine @jordan-powers